-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types: forkJoin(any)
and combineLatest(any)
return the wrong thing
#6226
Comments
benlesh
added a commit
to benlesh/rxjs
that referenced
this issue
Apr 14, 2021
benlesh
added a commit
that referenced
this issue
Apr 15, 2021
…6227) * fix: forkJoin/combineLatest return Observable<unknown> if passed any Resolves #6226 * chore: make shenanigans readonly Co-authored-by: Daniel Rosenwasser <[email protected]> * chore: Ensure there is no way the arg should work If the user passed that exact shape of object in AnyCatcher, technically it should work. This ensures there's no way it would work properly so `Observable<unknown>` is accurate. Also adds some documentation to the areas * refactor: Move any catcher signatures up Co-authored-by: Daniel Rosenwasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Basically, if we get an
any
to either one of these, we have no way of knowing if we're getting back an array or an object, so we need to returnunknown
.The text was updated successfully, but these errors were encountered: