Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retry): when # of retries is smaller than one #6359

Merged
merged 1 commit into from
May 5, 2021

Conversation

josepot
Copy link
Contributor

@josepot josepot commented May 4, 2021

Description:

Fixes #6358

Related issue (if exists):
#6358

@josepot josepot force-pushed the fix/retry branch 3 times, most recently from 4164e1f to 0d363ce Compare May 4, 2021 19:11
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cartant cartant added the 7.x Issues and PRs for version 7.x label May 4, 2021
@cartant cartant requested a review from benlesh May 4, 2021 21:18
@benlesh
Copy link
Member

benlesh commented May 5, 2021

Thanks, @josepot

@benlesh benlesh merged commit e797bd7 into ReactiveX:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Issues and PRs for version 7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retry(0) behavior changed in RxJS 7 and it is inconsitent with expectations (and documentation)
3 participants