Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs and issues umbrella #84

Closed
2 of 4 tasks
bvaughn opened this issue Oct 8, 2017 · 8 comments
Closed
2 of 4 tasks

Bugs and issues umbrella #84

bvaughn opened this issue Oct 8, 2017 · 8 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

We just completely rewrote docs in facebook/react/issues/7864.
They're bound to cause some issues, have some mistakes, etc.
Let's keep this issue as an umbrella for all problems we're discovering after the initial rollout.

Claimable

In-progress

  • @annuhdo: Mark mockComponent as legacy and unnecessary (react/issues/2499#issuecomment-94044857)
  • @ishankbahl: shallowCompare on Addons page should recommend PureComponent instead

If you'd like to claim any of the above items, leave a comment and we'll update this issue!

Migrated from facebook/react/issues/8035

@annuhdo
Copy link
Contributor

annuhdo commented Oct 9, 2017

Ooh, I'll grab the issue "Mark mockComponent as legacy and unnecessary" assuming it's to change this section: https://reactjs.org/docs/test-utils.html#mockcomponent

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 9, 2017

Okay it's yours

@ishankbahl
Copy link
Contributor

Made a PR for "shallowCompare on Addons page should recommend PureComponent instead".

@ishankbahl
Copy link
Contributor

@bvaughn the last two issues had been solved, maybe someone forgot to tick them off at facebook/react#8035 .

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 10, 2017

Yup! You're right! String refs are mentioned here and it looks like all of the forms examples show controlled components now. Thanks for pointing this out! Description has been updated.

@shawninder
Copy link

I added an issue about the docs in the wrong place so it was closed. Hopefully this is the right place: facebook/react#11221

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 17, 2017

Hey @shawninder 😄 This is the right repo. However, would you be willing to file your bug report as a new issue in this project? (Seems like this umbrella has outlived its usefulness.)

@bvaughn bvaughn closed this as completed Oct 17, 2017
@shawninder
Copy link

@bvaughn done #173

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
cc: @cezaraugusto vou aprovar essa PR. Uma vez que, ela é extremamente pequena e não há mudanças a serem feitas.
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants