-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [18] ReactDOM reference to createRoot/hydrateRoot * Update note about render and hydrate * Match the warning text * s/Render/render
* [18] Update ReactDOMClient docs * Remove ReactDOMClient where it's obvious * Update browser message * Update browser message note * Update based on feedback * Add react-dom/client docs
* [18] Switch code samples to createRoot * Feedback fixes * Feedback updates
* [18] Add flushSync to ReactDOM docs * Seb feedback * More Seb feedback
* [18] Update browser requirements * Update based on feedback
* [18] Add start/useTransition docs * Updates based on feedback
Comment on lines
-84
to
-87
> Note: | ||
> | ||
> `React.lazy` and Suspense are not yet available for server-side rendering. If you want to do code-splitting in a server rendered app, we recommend [Loadable Components](https:/gregberge/loadable-components). It has a nice [guide for bundle splitting with server-side rendering](https://loadable-components.com/docs/server-side-rendering/). | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
slorber
reviewed
Feb 15, 2023
changelog: https:/facebook/react/blob/main/CHANGELOG.md#1680-february-6-2019 | ||
url: https://5d4b5feba32acd0008d0df98--reactjs.netlify.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acdlite curious to know why you removed these Netlify permalinks.
Did they go offline without notice? I'm facing this problem on the Docusaurus versioning page: facebook/docusaurus#8634
Edit: nevermind, asking in #4482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds new docs for React 18.
See the commit list for a summary of all changes.
Note: this branch is still under development. To add docs to this branch, submit a PR against the
react-18
branch.