Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing repeating group number validation for nested repeating groups #518

Open
lucianoviana opened this issue Aug 16, 2024 · 1 comment

Comments

@lucianoviana
Copy link
Contributor

The repeating group number is currently validated against the actual group content, but this validation is missing when processing nested repeating groups.

For normal groups, the reject reason used is: INCORRECT_NUMINGROUP_COUNT_FOR_REPEATING_GROUP

unit test used as reference: uk.co.real_logic.artio.dictionary.generation.AbstractDecoderGeneratorTest#shouldDecodeNestedRepeatingGroups

@lucianoviana
Copy link
Contributor Author

Running the test above with the msg below, we get the following decoded RejectReason: REQUIRED_TAG_MISSING

FIX used as input to the test:

public static final String NESTED_GROUP_MESSAGE =
        "8=FIX.4.4\0019=77\00135=0\001115=abc\001116=2\001117=1.1\001127=19700101-00:00:00.001" +
        "\001120=1\001121=1\001122=1\001123=1\001123=1\00110=063\001";

The problem is when the NoNestedGrp is lower than the actual occurrences of NestedGroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant