Fixing flaky tests #517
Open
Fixing flaky tests #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
from
8623856
to
18b4b5a
Compare
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
7 times, most recently
from
c863950
to
323a381
Compare
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
5 times, most recently
from
21daab3
to
3b6712d
Compare
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
from
3b6712d
to
5277bdd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| public Statement apply(final Statement base, final Description description) | ||
| { | ||
| return new FailOnTimeout(base, LONG_TEST_TIMEOUT_IN_MS) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
| { | ||
| public Statement apply(final Statement base, final Description description) | ||
| { | ||
| return new FailOnTimeout(base, LONG_TEST_TIMEOUT_IN_MS) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
|
|
||
| return acceptor | ||
| .receivedMessage("2") | ||
| .anyMatch((message) -> msgSeqNo == Integer.parseInt(message.get(Constants.MSG_SEQ_NUM))); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
4 times, most recently
from
eb2e94d
to
7b08e9d
Compare
- using try-with-resources statement to initiate a FixConnection - returning workCount and trySend result to improve debugging
- SlowConsumerTest.sendMessage call is now protected against back pressure as it's now wrapped around a awaitSend call.
… just before writing to the tcp socket
-making PersistentSequenceNumberGatewayToGatewaySystemTest deterministic -fixing BinaryEntryPointClient call to jsonPrint when FIX_TEST is enabled -cancelOnDisconnect test was using wrong assumption on logout time -improving MessageBasedAcceptorSystemTest -improving SlowConsumerTest
-fixing a typo in testing code -checkstyle fix -ignoring socket closed exception when unexpectedly -adding more details when a socket disconnects unexpectedly
…mes it receives D replay before realtime msg
lucianoviana
force-pushed
the
fixing-flaky-tests
branch
from
7b08e9d
to
4261a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.