-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: better configs #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First past, see comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See a few comments below. Most of them are FYI mostly!
Nice refactoring and I guess it will make config management much easier. I also appreciate the nice and explicit variable naming (something that is underestimated IMO xD).
The repository is now at a size where it makes no sense to have arbitrary strings used as hyperparameter names.
This PR replaces the "giant-dict-as-config" with a structured & typed config, which makes each module responsible for defining & documenting its own configuration.
Tasks:
Because this is a "breaking" change this PR updates the minor version to 1, making this release
0.1.0
.