docs(README): Document how to test an in-development version of Baseplate in Snoodev #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTAtkinson
requested review from
nsheaps,
aba-ca-xi and
ghirsch-reddit
and removed request for
aba-ca-xi
nsheaps
reviewed
Oct 20, 2022
README.md
Outdated
| @@ -47,3 +47,25 @@ actions on push. | |||
| Specific hooks can be [temporarily disabled](https://pre-commit.com/#temporarily-disabling-hooks). | |||
|
|
|||
| You can install hooks only for a specific step (i.e. [pre-push](https://pre-commit.com/#pre-commit-during-push)). | |||
|
|
|||
| # Testing in Snoodev | |||
There was a problem hiding this comment.
🔕 Not against it here, and these instructions seem fine, but seems a little strange to me for this to be here but testing sidecars to be in the wiki
There was a problem hiding this comment.
Note that talks about how to release sidecars and then test them, not how to test them locally. Also currently this approach doesn't work with sidecars.
There was a problem hiding this comment.
🔕 nit: Multiple top-level headings in the same document
nsheaps
reviewed
Oct 20, 2022
| In this case the ref can be either a commit hash or a branch name. After making | ||
| this update you can check if the service works in Snoodev. | ||
|
|
||
| > **Warning** |
There was a problem hiding this comment.
TIL markdown syntax formats this
There was a problem hiding this comment.
I had to look it up :D
nsheaps
reviewed
Oct 20, 2022
nsheaps
approved these changes
Oct 20, 2022
Co-authored-by: Nathan Heaps <[email protected]>
ghirsch-reddit
approved these changes
Oct 20, 2022
RyanBalfanz
reviewed
Oct 20, 2022
Co-authored-by: Ryan Balfanz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks