-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting broken on import containing upper cased letters #351
Comments
Looks like a textmate bundle issue, though the same thing looks good in textmate itself. Maybe caused by a stale bundle in upstream vscode, although I tested with the latest Insiders build supposedly embedding a newer bundle. @snjeza can you check please? |
It works properly with microsoft/vscode#36708 |
@fbricon I have created the branch - https:/snjeza/vscode-java/tree/textmate that overrides the VS Code Java syntax highlighting and uses the original textmate syntax highlighting - https:/textmate/java.tmbundle. |
@snjeza any chance you can fix the upstream bundle instead? https:/atom/language-java/blob/master/grammars/java.cson |
@fbricon Will try. |
See atom/language-java#141 and atom/language-java#140 You can test the PR using the https:/snjeza/vscode-java/tree/issue-351 branch. |
@snjeza will vscode be able to override the atom settings, as described in atom/language-java#140 (comment)? |
I suppose it can't be used in VS Code because VS Code uses json. |
If I understand this right, the Atom Java grammar emits scope You either have to convince all theme authors to set that scope to the regular package color or you can tell users to do that themselves in the 'editor.colorCustomizations` setting:
Obvisouly that's not cool as So either we live with it or we switch to a different grammar. |
I'm happy to switch to a different grammar if you recommend me one. It can be of any format (json,cson,tmLanguage,pList)... |
@aeschli Could you just remove lines
in ./extensions/java/syntaxes/java.tmLanguage.json |
This is partially fixed with the new semantic highlighting support in vscode-java 0.61.0. Requires |
Try creating a java file with a package declaration containing upper cased letters, such as :
package org.gradle.apiImpl
Capital letters have a different colour:
The text was updated successfully, but these errors were encountered: