Response to the server request workspace/configuration #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdneo could you, please, rebase the PR? |
fbricon
reviewed
Sep 29, 2020
src/extension.ts
Outdated
| languageClient.onRequest(ConfigurationRequest.type, (params: ConfigurationParams) => { | ||
| const result: any[] = []; | ||
| const activeEditor: TextEditor | undefined = window.activeTextEditor; | ||
| for (const item of params.items) { |
There was a problem hiding this comment.
you should send java.format.insertSpaces and java.format.tabSize to align with https:/eclipse/eclipse.jdt.ls/pull/1551/files#diff-3feb2f2158f1898f0a00165abf820e3dR69-R73
|
Sure, will rebase it later today. |
jdneo
force-pushed
the
cs/workspace/configuration
branch
from
6fba515
to
cde9f88
Compare
Signed-off-by: Sheng Chen <[email protected]>
jdneo
force-pushed
the
cs/workspace/configuration
branch
from
cde9f88
to
d849a92
Compare
testforstephen
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details: eclipse-jdtls/eclipse.jdt.ls#1194
Signed-off-by: Sheng Chen [email protected]