Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable completion limit #1507

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Jun 30, 2020

following #1503, we can set java.completion.maxResults to a much larger value.

@fbricon
Copy link
Collaborator Author

fbricon commented Jun 30, 2020

@Eskibear @jdneo @testforstephen wdyt?

@jdneo
Copy link
Collaborator

jdneo commented Jun 30, 2020

Or maybe just use 0?

@Eskibear
Copy link
Contributor

Eskibear commented Jun 30, 2020

0 should be fine. 2000 doesn't solve the inconvinience brought by the "incomplete list" approach, like in #1276
Known max value for a typical project (spring-petclinic) is ~3000, with the 2000 limit I don't feel the difference, in both case there's a little bit lagging like hundreds of ms.

2000 is indeed a safe choice for large projects with more packages and classes (e.g. >10K candidates). We can change the description to tell users, they can set the limit for better performance but in trade of completeness.

The more the number is, the more cases where it gives a complete list. I'm ok with both, but prefer 0(infinite) for simplicity and less confusion. Then we only need to explain one thing:

  • When users get bad perf for extremely large projects, we point them to the setting.

Otherwise we'll also have to explain why the completion list sometimes is incomplete.

Signed-off-by: Fred Bricon <[email protected]>
@fbricon fbricon changed the title Increase max completion results to 2000 Disable completion limit Jun 30, 2020
@fbricon
Copy link
Collaborator Author

fbricon commented Jun 30, 2020

Ok, set limit to 0 (aka ∞)

@fbricon fbricon merged commit 4a97d91 into redhat-developer:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants