Add support for .class files #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaJHee
force-pushed
the
2679-class-file
branch
4 times, most recently
from
f9a3dac
to
20e5e74
Compare
|
Here is the current behavior of this PR:
|
rgrunber
reviewed
Mar 14, 2023
rgrunber
reviewed
Mar 14, 2023
rgrunber
reviewed
Mar 14, 2023
JessicaJHee
force-pushed
the
2679-class-file
branch
from
20e5e74
to
80f9e86
Compare
rgrunber
reviewed
Mar 15, 2023
JessicaJHee
force-pushed
the
2679-class-file
branch
from
80f9e86
to
b5adea8
Compare
rgrunber
reviewed
Mar 17, 2023
rgrunber
reviewed
Mar 17, 2023
JessicaJHee
force-pushed
the
2679-class-file
branch
from
b5adea8
to
c7fea83
Compare
rgrunber
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
One very minor thing, and then just fix up the language-server side command at eclipse-jdtls/eclipse.jdt.ls#2515 (review) . Then I think we can merge.
JessicaJHee
force-pushed
the
2679-class-file
branch
from
c7fea83
to
e67c557
Compare
Signed-off-by: Jessica He <[email protected]>
JessicaJHee
force-pushed
the
2679-class-file
branch
from
e67c557
to
2d180d1
Compare
|
@rgrunber Thank you very much for your review!
|
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2679
Requires eclipse-jdtls/eclipse.jdt.ls#2515