feat: Import tenacity library and use it in cluster_read.py
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomh
force-pushed
the
pablomh-retry
branch
from
70d7f91
to
cbfcfef
Compare
jhutar
reviewed
Jan 12, 2024
core/opl/cluster_read.py
Outdated
| @@ -178,6 +179,7 @@ def _sanitize_target(self, target): | |||
| target = target.replace("$Cloud", self.args.grafana_prefix) | |||
| return target | |||
|
|
|||
| @retry | |||
There was a problem hiding this comment.
How many times it will retry?
jhutar
reviewed
Jan 12, 2024
pablomh
force-pushed
the
pablomh-retry
branch
from
cbfcfef
to
94cf728
Compare
Use it to retry POST requests to Grafana which seems to close/reset connections under load. [Tenacity](https://tenacity.readthedocs.io/en/latest/)
pablomh
force-pushed
the
pablomh-retry
branch
6 times, most recently
from
40f5c30
to
6b91480
Compare
pablomh
force-pushed
the
pablomh-retry
branch
from
6b91480
to
ba78d27
Compare
jhutar
approved these changes
Jan 14, 2024
jhutar
reviewed
Jan 14, 2024
| @@ -178,6 +179,8 @@ def _sanitize_target(self, target): | |||
| target = target.replace("$Cloud", self.args.grafana_prefix) | |||
| return target | |||
|
|
|||
| # pylint: disable-next=undefined-variable | |||
| @retry(stop=(stop_after_delay(10) | stop_after_attempt(10))) # noqa: F405 | |||
There was a problem hiding this comment.
BTW never used | in python, thanks! https://stackoverflow.com/questions/5988665/pipe-character-in-python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it to retry POST requests to Grafana which seems to close/reset connections under load.
Tenacity