-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection task cancel doesn't clean up and hangs #2511
Labels
bug
Bug
Comments
tobymao
changed the title
https:/redis/redis-py/issues/new/choose
Connection task cancel doesn't clean up and hangs
Dec 14, 2022
Closing as I assume this issue was fixed with all the async and CancelledError fixes. @tobymao Feel free to re-open it if this still happen to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: What redis-py and what redis version is the issue happening on?
v4.4.0
specifically this commit
9fe8366
Platform: What platform / version? (For example Python 3.5.1 on Windows 7 / Ubuntu 15.10 / Azure)
arch linux, python 3.10
Description: Description of your issue, stack traces from errors and code that reproduces the issue
The change in async def read_response BaseException -> Exception causes my unit tests to hang forever
I need to terminate redis to stop the process from hanging.
https:/tobymao/saq/blob/master/tests/test_worker.py#L71
This is the unit test that fails. You can follow the SAQ install instructions to run that unit test.
Changing back to BaseException fixes the issue. My guess is because in the unit test, I cancel the task, and the error handling in redis-py doesn't disconnect when a task is cancelled anymore.
The text was updated successfully, but these errors were encountered: