Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch Exception and not BaseException in the Connection #2104

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Catch Exception and not BaseException in the Connection #2104

merged 3 commits into from
Sep 29, 2022

Commits on Sep 28, 2022

  1. Add failing unittests for passing BaseException through

    @kristjanvalur
    kristjanvalur committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    a13b28c View commit details
    Browse the repository at this point in the history

  2. Resolve failing unittest

    @kristjanvalur
    kristjanvalur committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    0c5679a View commit details
    Browse the repository at this point in the history

  3. Remove redundant checks for asyncio.CancelledError

    @kristjanvalur
    kristjanvalur committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    26058fa View commit details
    Browse the repository at this point in the history