Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 EOL #2852

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Python 3.7 EOL #2852

merged 1 commit into from
Aug 2, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 18, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (2732a85) 90.65% compared to head (265f608) 90.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2852      +/-   ##
==========================================
- Coverage   90.65%   90.63%   -0.03%     
==========================================
  Files         126      126              
  Lines       32229    32229              
==========================================
- Hits        29217    29210       -7     
- Misses       3012     3019       +7     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim
Copy link
Contributor Author

chayim commented Jul 18, 2023

closes #2824

@chayim chayim added the breakingchange API or Breaking Change label Jul 18, 2023
@dvora-h dvora-h merged commit dc62e19 into master Aug 2, 2023
54 checks passed
@dvora-h dvora-h deleted the ck-eol branch August 2, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants