Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESP3 connection examples #2863

Merged
merged 2 commits into from
Aug 2, 2023
Merged

RESP3 connection examples #2863

merged 2 commits into from
Aug 2, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 25, 2023

As part of adding support for RESP3 in 5.x we need to communicate to our users how to enable RESP 3. This PR contains three items:

  1. A basic example for the README

  2. Updates to the sync examples, to share a redis_url style connection, as well as a basic connection, with RESP3

  3. An async example highlighting the protocol=3 usage with async.

While here, I modified the async examples to include a URL based connection example, as one was missing

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (2732a85) 90.66% compared to head (19eac07) 90.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2863      +/-   ##
==========================================
- Coverage   90.66%   90.63%   -0.04%     
==========================================
  Files         126      126              
  Lines       32229    32229              
==========================================
- Hits        29221    29210      -11     
- Misses       3008     3019      +11     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim requested a review from dvora-h July 26, 2023 07:36
@chayim
Copy link
Contributor Author

chayim commented Aug 2, 2023

needs #2869 at least

@chayim chayim merged commit a49e656 into master Aug 2, 2023
52 of 53 checks passed
@chayim chayim deleted the resp3docs branch August 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants