Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async sentinel: add push_request keyword argument to read_response #2922

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 31, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2921

@dvora-h dvora-h added the bug Bug label Aug 31, 2023
@dvora-h dvora-h requested a review from a team August 31, 2023 10:45
@dvora-h dvora-h merged commit 8c8a529 into redis:master Sep 11, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async Sentinel is broken for pubsub
2 participants