Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace clear_connect_callbacks with _deregister_connect_callback #2955

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Sep 20, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This change seems to have been missed in #2870 (@kristjanvalur)

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Sep 20, 2023
@dvora-h dvora-h requested a review from chayim September 20, 2023 22:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ded9f7c) 91.36% compared to head (a153c80) 91.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2955   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         126      126           
  Lines       32603    32603           
=======================================
+ Hits        29787    29789    +2     
+ Misses       2816     2814    -2     
Files Changed Coverage Δ
redis/asyncio/client.py 91.98% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI...

@dvora-h dvora-h merged commit 1b370da into redis:master Sep 21, 2023
56 of 57 checks passed
@kristjanvalur
Copy link
Contributor

How did that happen?

@kristjanvalur
Copy link
Contributor

kristjanvalur commented Sep 21, 2023

Ah, it is in a __del__ handler. In fact, this code is not required and the __del__ handler can be removed, since the callbacks are weak andyway, the reason being to precisely not need __del__.
But I did grep for the function, so my bad on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants