Merge pull request #22917 from vbotbuildovich/backport-pr-22912-v24.2…

….x-912 [v24.2.x] tx: do not throw USE on expired transaction_ids
redpanda-data · Aug 19, 2024 · ab8c4f5 · ab8c4f5
2 parents 942a318 + 25a2d80
commit ab8c4f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/v/cluster/tx_gateway_frontend.cc b/src/v/cluster/tx_gateway_frontend.cc
@@ -1784,7 +1784,7 @@ ss::future<tx_gateway_frontend::op_result_t> tx_gateway_frontend::do_end_txn(
  "commit/abort",
  request.transactional_id,
  pid);
- err = tx::errc::unknown_server_error;
+ err = tx::errc::invalid_producer_id_mapping;
  }
  outcome->set_value(err);
  co_return err;

diff --git a/tests/rptest/transactions/transactions_test.py b/tests/rptest/transactions/transactions_test.py
@@ -420,8 +420,9 @@ def transaction_id_expiration_test(self):
  try:
  producer.commit_transaction()
  assert False, "transaction should have been aborted by now."
- except ck.KafkaException:
- pass
+ except ck.KafkaException as e:
+ assert e.args[0].code(
+ ) == ck.KafkaError.INVALID_PRODUCER_ID_MAPPING, f"Invalid error thrown on expiration {e}"
 
  @cluster(num_nodes=3)
  def expired_tx_test(self):