[v23.2.x] log_eviction_stm: further cleanup #12489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the queue-based signaling in log_eviction_stm, which proved to be a bit error prone. Instead, this reverts to the old implementation using a condition_variable, but leaves out the offset monitor, which doesn't seem needed. Now, either storage or delete-records will bump their respective offsets, and the event-processing loop will take the higher and truncate to it. If this isn't finished, the process is repeated after some timeout. (cherry picked from commit 6a723a7)
- The log_eviction_stm had an issue where a deadlock could occur if an event from storage requested to evict at an offset that was below the raft last snapshot index. - This is because the code in the above scenario would wait but then go down a path where .notify() was never called. - This unit test reproduces the scenario described and ensures that future edits to the eviction_stm do not re-introduce this problem. (cherry picked from commit aa7b9fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12476
Removes the queue-based signaling in log_eviction_stm, which proved to
be a bit error prone.
Instead, this reverts to the old implementation using a
condition_variable, but leaves out the offset monitor, which doesn't
seem needed.
Now, either storage or delete-records will bump their respective
offsets, and the event-processing loop will take the higher and truncate
to it. If this isn't finished, the process is repeated after some
timeout.
Backports Required
Release Notes