Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override --config on some commands #693

Closed
alenkacz opened this issue Feb 25, 2021 · 1 comment · Fixed by #852
Closed

Do not override --config on some commands #693

alenkacz opened this issue Feb 25, 2021 · 1 comment · Fixed by #852
Assignees
Labels
area/rpk kind/bug Something isn't working

Comments

@alenkacz
Copy link
Contributor

alenkacz commented Feb 25, 2021

it looks like RPK has a global flag --config https:/vectorizedio/redpanda/blob/dev/src/go/rpk/pkg/cli/cmd/api.go#L38 but also some commands specify their own --config that silently overrides it e.g. https:/vectorizedio/redpanda/blob/dev/src/go/rpk/pkg/cli/cmd/topic/create.go#L91 so then if you try to do --config redpanda.yml on that command, it won't work

@alenkacz alenkacz added kind/bug Something isn't working area/rpk labels Feb 25, 2021
@emaxerrno
Copy link
Contributor

good find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants