Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] Add rate-rejected connection metric #22816

Merged
merged 3 commits into from
Aug 10, 2024
Merged

[v24.2.x] Add rate-rejected connection metric #22816

merged 3 commits into from
Aug 10, 2024

Commits on Aug 9, 2024

  1. net: adjust rejected connection metric help text 

    Adjust the existing metric text to clarify that is connections
rejected for hitting the connection count cap, not the connection
rate limit cap (as we are shortly introducing a metric for the
latter).

Ref CORE-6827.

(cherry picked from commit daf4917)
    @travisdowns @vbotbuildovich
    travisdowns authored and vbotbuildovich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a38c289 View commit details
    Browse the repository at this point in the history

  2. net: make rejected connection naming consistent 

    We can reject connections because we hit two types of limits: the
open connection limit or the rate limit (in the rate limit case
we do try to wait a short period to see if accepting the connection
after the wait would meet the rate, but if not we reject).

Existing naming of variables, log lines etc was inconsistent using
"declined" for the second case and generally not being clear about
the two cases.

Bring this into line by using "rejected" as the standard terminology
and then "open limit" and "rate limit" being the two reasons.

Log the addr in the same way too, including the port, in either case.

(cherry picked from commit e55a2be)
    @travisdowns @vbotbuildovich
    travisdowns authored and vbotbuildovich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8717e31 View commit details
    Browse the repository at this point in the history

  3. net: add rate-rejected connection metric 

    Add connections_rejected_rate_limit which counts connections rejected
due to the rate limit, analogously to the existing metric which counts
rejected connections due to the hitting the open connection limit.

Fixes CORE-6827.

(cherry picked from commit b1f3372)
    @travisdowns @vbotbuildovich
    travisdowns authored and vbotbuildovich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2a35b3d View commit details
    Browse the repository at this point in the history