[v24.2.x] c/tx_gateway: made end_txn fully idempotent when committing transaction
#22941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transaction is committed the process may be interrupted in any of the steps i.e. before replicating the `preparing_commit` state update, before requesting data partitions to commit transaction or before replicating `completed_commit` state update. When an `end_txn` request is retried by the client `tx_gateway` try to progress the transaction before it is returned for further processing in either commit or abort handling method. It may be the case that the transaction progress all the way to `completed_commit` state, in this case Redpanda should return a success to client as the transaction was finished. Fixed a bug leading to the situation in which an invalid transaction state error was returned when transaction was progressed to `completed_commit` phase before entering a commit transaction handler. The fix makes the `EndTxn` request fully idempotent. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 2835bb0)
mmaslankaprv
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22937