schema_registry: Support default null type in union for Avro #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Avro, nil type in a union is supported for backwards compatibility, if it's also the default. The default value must be of the type of the first type in the union. This change allows that. Fixes redpanda-data#4120
dotnwat
approved these changes
Mar 28, 2022
|
Unrelated test failures. |
|
/backport v21.11.x |
|
Beautiful pr. |
BenPope
added
kind/bug
BenPope
added a commit
that referenced
this pull request
Mar 29, 2022
Backport #4129: schema_registry: Support default nil type in union for Avro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
For Avro, null type in a union is supported for backwards compatibility,
if it's also the default. The default value must be of the type of the
first type in the union.
This change allows that.
Fixes #4120
Release notes
Improvements