Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulties Running #9

Open
itsagoodbrain opened this issue Aug 30, 2022 · 5 comments
Open

Difficulties Running #9

itsagoodbrain opened this issue Aug 30, 2022 · 5 comments

Comments

@itsagoodbrain
Copy link

I appreciate the code release, however, this was pretty difficult to get running. I managed to get there but the bar for the results was raised by the effort. I think it might be good to revisit a few things.

Here's things that I think would help others be able to use it

  • Provide some information about your build environment/requirements
  • Make the DCNv2 a submodule and perhaps make the import work independent of location
  • Make symlinks in each model for libs and utils if you're going to import them in the scripts
  • Remove hard coded inputs, especially those pointing to your home directory etc
@itsagoodbrain
Copy link
Author

I also found that there isn't a sequence_test.py for each model. I worked on creating my own for VDN but it seems the feed forward network requires the noise map and as best I can tell it is the generated noise. Is this correct?

@redrock303
Copy link
Owner

I also found that there isn't a sequence_test.py for each model. I worked on creating my own for VDN but it seems the feed forward network requires the noise map and as best I can tell it is the generated noise. Is this correct?

Sorry for that. In fact, the noise map refers to the noise level, where all the elements have the same values (i.e. 20), As described in our paper, "In this task, we aim to remove Gaussian white noises with known noise levels".

@itsagoodbrain
Copy link
Author

I see. Thanks for clarifying. I think I can manage. Would you like a PR with some changes to review or is my feedback here sufficient?

@itsagoodbrain
Copy link
Author

And would it be possible to release the missing sequence_test.py for VDN? In the README it's the only one specified which isn't there in the repo.

@redrock303
Copy link
Owner

I see. Thanks for clarifying. I think I can manage. Would you like a PR with some changes to review or is my feedback here sufficient?

I appreciate your PR. Thanks for your good suggestion, and I will upload this script soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants