Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) update test snapshot #271

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Dec 5, 2019

Since a few days, the tests are failing - it seems that updating this inline snapshot has been forgotten in #257 or some serializer was added afterwards. No matter why, this will make the tests green again.

@netlify
Copy link

netlify bot commented Dec 5, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit 4cbbd7a

https://deploy-preview-271--redux-starter-kit-docs.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 5, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4cbbd7a:

Sandbox Source
focused-bhaskara-vz1eo Configuration
compassionate-cookies-zbbul Configuration
rsk-github-issues-example Configuration

@phryneas
Copy link
Member Author

phryneas commented Dec 5, 2019

Okay, that makes codesandbox green and travis red, before that it was the other way round. 🤔

Maybe this is something with different node versions? I'll investigate this later and leave this PR up as a reminder.

@phryneas
Copy link
Member Author

phryneas commented Dec 5, 2019

Ah well, since the value is serialized differently in different systems I guess the most practical approach is just to match until the beginning of the serialized string. It's all about that path anyways.

@phryneas
Copy link
Member Author

phryneas commented Dec 5, 2019

@markerikson are you fine with me merging this?

(For reference, this was the error: https://ci.codesandbox.io/status/reduxjs/redux-toolkit/pr/270 )

@markerikson
Copy link
Collaborator

Sure, go ahead.

@phryneas phryneas merged commit afc11d9 into reduxjs:master Dec 6, 2019
@kevin940726
Copy link
Contributor

kevin940726 commented Dec 10, 2019

Oops! Actually I've encountered similar issue not long after sending the PR. Turns out that util.inspect outputs different format in different node versions. I created console-testing-library to solve this issue. It uses pretty-format from jest to normalize the output across different environments.

This solution with regex works fine, but if we want the tests to more represent the actual output, I can try integrate console-testing-library in another PR. (Though I think it might be an overkill for this library.)

@phryneas
Copy link
Member Author

@kevin940726 I'd love this to be less hacky - and since your console-testing-library doesn't add any additional dependencies we aren't already using (besides itself), I'd say go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants