-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'refaktor:main' into main
- Loading branch information
Showing
102 changed files
with
2,147 additions
and
1,879 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
CODE OF CONDUCT | ||
# CODE OF CONDUCT | ||
|
||
1. Be nice and respectfull to others | ||
The idea is that we shouldn't have too many principles or rules. We are not trying to create a bureaucracy. Just the really necessary ones, the rest is more like advice or knowledge base. | ||
|
||
## Principles we try to follow | ||
|
||
1. Be nice and respectful to others | ||
2. Try to add value with your activity | ||
3. Criticism is perfectly OK, but be constructive and respect points 1. and 2. | ||
4. When trying to contribute follow the [CONTRIBUTING](CONTRIBUTING.md) directives |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,25 @@ | ||
# Contributing | ||
|
||
## Before PR-s | ||
When trying to contribute try to follow directives below, to make the progress of the project streamlined and Rye up to certain quality. | ||
|
||
## Before opening a PR | ||
* Open and issue so we can make a discussion first | ||
|
||
## Making PR-s | ||
* Main branch shouldn't be left in a failed state (the red cross) | ||
* PRs that are meant for merging should also pass all checks | ||
## When making a PR | ||
* PRs that are meant for merging should pass all checks | ||
* Each new builtin should have a docstring written and at least few tests | ||
|
||
## In general | ||
* Main branch shouldn't be left in a failed state (the red cross) | ||
|
||
## Q&A | ||
|
||
### How to create commits / PR-s / merge them so that feed and release notes are as informative as possible? | ||
|
||
If there is only one commit per PR then the message is stored and used. | ||
|
||
If there are multiple commits's then messages get lost unless we merge with *Squash and merge*. This joins messages together and uses them (positive) but also joins all code changes into one commit. | ||
A) If reason for multiple commits is iterating on a set of changes, or making them comple (adding tests, making golint-ci pass, ...) then this makes sense. | ||
B) If PR is composed of multiple commits each for different set of changes then some information is lost with Squash, maybe these should be multiple PR-a. | ||
|
||
_This is work in progress, you can propose improvements._ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
go build -tags "b_sqlite,b_http,b_sql,b_postgres,b_bson,b_mail,b_bcrypt,b_telegram,b_html,b_email,b_mail,b_mysql,b_fyne,b_contrib,b_bleve,b_devops,b_ssh," -o bin/rye | ||
go build -o bin/rye |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.