Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvements]Error handling completed for builtins.go file #22

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. All remaining Error handlings completed for builtins.go
  2. removed unused return nil
  3. added TODODOC at some place
  4. Added TODO-FIXME at some place
    Rye-itself//needs : Inside if condition - logic need to write. Added TODO-FIXME
    ncols : for Dic and Block need to add logic so added TODO-FIXME
  5. Observation
    ioutil.ReadFile - It is deprecated in go 1.16
    Now os.ReadFile function is introduced for the latest go version.
    In future, we need to replace given functions.

@refaktor refaktor merged commit 739e43b into refaktor:main Nov 9, 2023
@refaktor
Copy link
Owner

refaktor commented Nov 9, 2023

This is great! Core builtins are done ... I will be adding the docstrings and other fixes that you marked for me. Thank you.

@pratikmota pratikmota deleted the error-handling-6 branch November 9, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants