Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod tidy, go 1.21 #52

Merged
merged 3 commits into from
Dec 10, 2023
Merged

go mod tidy, go 1.21 #52

merged 3 commits into from
Dec 10, 2023

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Dec 10, 2023

No description provided.

io/ioutil is deprecated, warning was:
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)
@stefanb stefanb changed the title go mod tidy go mod tidy, go 1.21 Dec 10, 2023
@refaktor
Copy link
Owner

Thank you for bumping Go up and changing io/ioutil to io / os !
I haven't decided to use "go tidy" so far because it adds all the optional dependencies to go.mod, but I agree to have this setup as long as we don't create better mechanism for selecting additional modules. Thank you!

@refaktor refaktor marked this pull request as ready for review December 10, 2023 21:55
@refaktor refaktor merged commit 289098e into refaktor:main Dec 10, 2023
2 checks passed
@stefanb
Copy link
Contributor Author

stefanb commented Dec 11, 2023

For a few modules i had to find a specific, non-latest version for things to work. Those were problematic when trying to get them using go-get-*.bash files, as there was no version defined, so it undeterministically tried to use the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants