Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automerge for version or migrations only #1063

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

CJ-Wright
Copy link
Member

Note that this will need a PR in webservices to make the most of this and some advertising.

The hope here is that ABI migration PRs are more likely to break if there are any changes that need to be applied to the feedstock. Enabling migration automerge will greatly speed up uptake of pins, similar to the R 4.0 migration.

@beckermr @isuruf @scopatz

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #1063 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files          53       53           
  Lines        5087     5087           
=======================================
  Hits         2922     2922           
  Misses       2165     2165           
Impacted Files Coverage Δ
conda_forge_tick/migrators/migration_yaml.py 64.32% <ø> (ø)
conda_forge_tick/migrators/version.py 79.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b9502...b46dbb7. Read the comment docs.

@beckermr
Copy link
Contributor

IDK what the webservices has to do with this. Do you mean a PR in the automerge action code?

@CJ-Wright
Copy link
Member Author

Don't we have a admin command to add automerge keys to the conda-forge.yml?

@beckermr
Copy link
Contributor

Yes. Did you want variations of that command?

@CJ-Wright
Copy link
Member Author

I think that would be awesome! Unless we're interested in setting the default to automerge for migrations only

@CJ-Wright CJ-Wright merged commit b8aa909 into regro:master Jul 25, 2020
@CJ-Wright CJ-Wright deleted the multi_automerge branch July 25, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants