Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pathfinder_simd to 0.5.4 #45

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Updated pathfinder_simd to 0.5.4 #45

merged 4 commits into from
Aug 15, 2024

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Aug 14, 2024

Updated pathfinder_simd dependency to v0.5.4 to make starknet-replay compatible with nightly (currently 1.82) version of Rust on ARM.

Also added Nightly build on CI.

Closes #43 .

@Eagle941 Eagle941 marked this pull request as ready for review August 15, 2024 00:27
iamrecursion
iamrecursion previously approved these changes Aug 15, 2024
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it a Rust version mismatch?

Base automatically changed from apple_silicon_runner to main August 15, 2024 17:47
@Eagle941 Eagle941 dismissed iamrecursion’s stale review August 15, 2024 17:47

The base branch was changed.

@Eagle941
Copy link
Contributor Author

Was it a Rust version mismatch?

Yes. The CI is hardcoded to use 1.78, but there is no toolchain file to ensure users use 1.78. Starting from Rust 1.80, an ARM feature [1] became stable and broke the compilation of pathfinder_simd [2].

[1] rust-lang/stdarch#1573
[2] servo/pathfinder#565

@Eagle941 Eagle941 merged commit bd2dcde into main Aug 15, 2024
7 checks passed
@Eagle941 Eagle941 deleted the update_pathfinder_simd branch August 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependency on pathfinder_simd for Mac
2 participants