-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.13.3] HistoryLocation no longer fires run
callback
#1833
Comments
This was referenced Sep 6, 2015
After digging into the issue like crazy, the best I can assume is that context or something goes haywire. That's the best I've got. Anyway, released React Resolver v2.0.5 with a fix that just neuters some functionality since it's a common edge-case:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
First, I apologize if this issue is covered elsewhere, but my searching didn't turn up either a solution.
The issue was first discovered in ericclemmons/react-resolver#75 & ericclemmons/react-resolver#78.
Given:
and the usual:
You can see routing stops working after the history changes the first time:
However, React Router v1.0.0-beta3 works as expected:
In my testing,
HashLocation
works correctly.Is this a not-so-obvious error on my part, or something that will need a more time-intensive test-case to reason about? 😜
The text was updated successfully, but these errors were encountered: