-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should fail if assets are missing. #36
Labels
Comments
Could you describe the options that you used? It passes without any assets? |
Sure: util.promisify(release)({
token,
owner: "cosmos",
repo: "voyager",
tag,
name: `Cosmos Voyager Alpha ${tag} (UNSAFE)`,
notes: `
NOTE: DO NOT ENTER YOUR FUNDRAISER SEED. THIS SOFTWARE HAS NOT BEEN AUDITED.
NEVER ENTER YOUR FUNDRAISER SEED 12 WORDS ONTO AN ONLINE COMPUTER.
Even when we do start supporting fundraiser seeds, don't use it except for
testing or with small amounts. We will release a CLI to use for offline signing
of transactions, and we will also add hardware support for this UI.
Please checkout the [CHANGELOG.md](CHANGELOG.md) for a list of changes.
`,
draft: false,
prerelease: true,
skipAssetsCheck: false,
assets: [
path.join(__dirname, `../builds/Cosmos Voyager-darwin-x64_${tag}.tar.gz`),
path.join(__dirname, `../builds/Cosmos Voyager-linux-x64_${tag}.tar.gz`),
path.join(__dirname, `../builds/Cosmos Voyager-win32-x64_${tag}.zip`)
]
}) It published the release even though the assets weren't where they were supposed to be and If I were to hazard a quick guess it's because the code should be calling Line 53 in 26df696
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When an asset is missing the release is partially published. It should be all-or-nothing.
The text was updated successfully, but these errors were encountered: