-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making ColorScheme immutable #675
Comments
(Thinking out loud, unsure if this could be made to work...) Ideas for superclass names:
|
Yes, I think it's a great opportunity personally. On a related note, have you looked at the JLine3 abstractions in this area for inspiration? I'm not sure they are inline with what you are thinking, but there does look like some good thoughts here. https:/jline/jline3/tree/master/terminal/src/main/java/org/jline/utils In particular the |
Following up on #516.
With the new
execute
API the ColorScheme class will start to play a more central role.I’m considering making the ColorScheme class immutable. This will be a breaking API change. Should it be deprecated first, or not changed at all, or is the upcoming 4.0 release a good time to make breaking changes?
Feedback very welcome!
(cc @bobtiernay-okta @bbottema )
The text was updated successfully, but these errors were encountered: