Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags for empty sections in adoc man page #1338

Merged
merged 3 commits into from
Mar 4, 2021
Merged

add tags for empty sections in adoc man page #1338

merged 3 commits into from
Mar 4, 2021

Conversation

crotwell
Copy link
Contributor

@crotwell crotwell commented Mar 3, 2021

addresses issue #1337

@remkop remkop added this to the 4.6.2 milestone Mar 4, 2021
@remkop remkop added theme: codegen An issue or change related to the picocli-codegen module type: enhancement ✨ labels Mar 4, 2021
@remkop
Copy link
Owner

remkop commented Mar 4, 2021

I like this idea, and almost merged it, but I noticed that there are failing tests in the Travis CI build after this change.

They all seem to be in picocli.codegen.docgen.manpage.ManPageGeneratorTest as far as I can see.

Can you take a look at that?

@crotwell
Copy link
Contributor Author

crotwell commented Mar 4, 2021

Think test resources are now ok, at least tests pass locally. WIll see what travis decides...

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1338 (ae7522f) into master (757ce3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1338   +/-   ##
=========================================
  Coverage     93.76%   93.76%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6961     6961           
  Branches       1869     1869           
=========================================
  Hits           6527     6527           
  Misses          147      147           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757ce3d...ae7522f. Read the comment docs.

@remkop remkop merged commit 8a97b5d into remkop:master Mar 4, 2021
remkop added a commit that referenced this pull request Mar 4, 2021
@remkop
Copy link
Owner

remkop commented Mar 4, 2021

Merged. Thank you for the contribution!

@crotwell crotwell deleted the gen-empty-man-tags branch March 4, 2021 13:43
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…g WARNING messages when generating man pages"

This reverts commit c84fcde.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…g WARNING messages when generating man pages"

This reverts commit c84fcde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: codegen An issue or change related to the picocli-codegen module type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants