Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodemon won't kill previous process after upgrade from node v10 to v16 #1936

Closed
talhaanees opened this issue Oct 14, 2021 · 8 comments
Closed

Comments

@talhaanees
Copy link

  • Versions: Node 16.0.0, win32 Windows 10 x64, OS 10.0.19043, Electron 11.4.10
  • nodemon -v: 2.0.13

Expected behaviour

Nodemon would kill the previous electron process and restart after changes occur

Actual behaviour

Nodemon starts a new process (sometimes multiple processes) when the changes occur. Every save does this

Steps to reproduce

Everything was working fine with node v10. This started happening after upgrading to node v16. I have tried passing --signal in the command, which doesn't work.

the script that I run is is:
"electron-watch": "nodemon --watch ./electron.cjs --exec "npm run electron-start""

Any ideas why this started happening after the upgrade and how I can fix it?

@remy
Copy link
Owner

remy commented Oct 14, 2021

No idea, but try node 14 to see if you can narrow it down?

@immortalmind2016
Copy link
Contributor

@remy i think this issue related to this PR : #1938

@remy
Copy link
Owner

remy commented Oct 18, 2021

Can people following this thread test with npm i nodemon@debug and confirm if this works or not - this is the latest change with @immortalmind2016's changes.

@Sigmanor
Copy link

Can people following this thread test with npm i nodemon@debug and confirm if this works or not - this is the latest change with @immortalmind2016's changes.

seems with npm i nodemon@debug it's working correctly

@remy
Copy link
Owner

remy commented Oct 21, 2021

This is live in the latest release, so we can close this then.

@remy remy closed this as completed Oct 21, 2021
@talhaanees
Copy link
Author

Confirmed this issue is resolved with nodemon v: 2.0.14!

@JoeyFlaum
Copy link

@remy Still running into issues. Nothing is working. Please help.

[nodemon] 2.0.15
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,json
[nodemon] starting `node server.js`
Server is running on port 3000
rs
[nodemon] restarting due to changes...
[nodemon] restarting due to changes...
[nodemon] restarting due to changes...

@remy
Copy link
Owner

remy commented Nov 10, 2021

@JoeyFlaum can you file a new issue with details on how to replicate with pared down code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants