Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests directory from installation #209

Closed
D3vil0p3r opened this issue Dec 25, 2023 · 2 comments · Fixed by #210
Closed

Exclude tests directory from installation #209

D3vil0p3r opened this issue Dec 25, 2023 · 2 comments · Fixed by #210

Comments

@D3vil0p3r
Copy link

The install of grammarinator generates /usr/lib/python3.11/site-packages/tests/__init__.py that creates conflicts with other Python packages that install tests directory (and that need to be fixed too).

It is needed also according to Python package guidelines.

Can you please exclude tests in your pyproject.toml file?

Give a look to https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html and search for exclude keyword.
@D3vil0p3r D3vil0p3r mentioned this issue Dec 25, 2023
Closed
2 tasks
akosthekiss added a commit to akosthekiss/grammarinator that referenced this issue Dec 25, 2023
@akosthekiss
Fix leftover path problems
18cf8e4 
- When tool API got split from CLI, MANTIFEST.in was not updated to
  exclude the right files.
- When test folder got changed into a package, setup.cfg was not
  updated to exclude the new package from the distribution.

Fixes renatahodovan#209
@akosthekiss akosthekiss mentioned this issue Dec 25, 2023
Merged
renatahodovan pushed a commit that referenced this issue Dec 25, 2023
@akosthekiss
Fix leftover path problems (#210)
f3ffa71 
- When tool API got split from CLI, MANTIFEST.in was not updated to
  exclude the right files.
- When test folder got changed into a package, setup.cfg was not
  updated to exclude the new package from the distribution.

Fixes #209
@akosthekiss
Copy link
Collaborator

@D3vil0p3r Thanks for reporting the issue. Hopefully fixed now. Could you please confirm whether the original issue is resolved?

@D3vil0p3r
Copy link
Author

It is. Thank you.

@D3vil0p3r Thanks for reporting the issue. Hopefully fixed now. Could you please confirm whether the original issue is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix leftover path problems akosthekiss/grammarinator
2 participants
@akosthekiss @D3vil0p3r