Ensure that every inline parser literal has its corresponding lexer rule #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
requested changes
Sep 24, 2023
| # This file may not be copied, modified, or distributed except | ||
| # according to those terms. | ||
|
|
||
| # This custom unparser is used by ImplicitLiterel.g4 |
There was a problem hiding this comment.
typo: ImplicitLiterel.g4 -> ImplicitLiteral.g4
grammarinator/tool/processor.py
Outdated
| graph.add_edge(frm=parent_id, to=graph.add_node(LiteralNode(src=src))) | ||
| else: | ||
| # Ensure that every inline literal in parser rules has its lexer rule | ||
| # found or implicitely created. |
There was a problem hiding this comment.
typo: implicitely -> implicitly
By following ANTLR's practice, every inline parser rule literal is converted into a lexer rule. Either by finding an approrpiate existing lexer rule or by artificially creating one and assigning its reference to the literal usage.
renatahodovan
force-pushed
the
imp-lit
branch
from
a0ce0dd
to
1980d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By following ANTLR's practice, every inline parser rule literal is converted into a lexer rule. Either by finding an appropriate existing lexer rule or by artificially creating one and assigning its reference to the literal usage.