-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate's GH Actions updates propose to delete YAML inline comments #12260
Comments
I think this is because we also have code that can "pin" a GitHub action to a full length commit SHA. I suspect this code removes any existing comments to "prepare" for commit SHA pinning later on. Renovate uses a comment to tell you what "version tag" it's using for the full length commit hash. So you have a human readable version instead of just commit hash gibberish. https:/renovatebot/renovate/blob/main/lib/manager/github-actions/extract.ts |
Minimal reproduction: https:/renovate-reproductions/12260 |
🎉 This issue has been resolved in version 32.7.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
How are you running Renovate?
WhiteSource Renovate hosted app on github.com
Please select which platform you are using if self-hosting.
No response
If you're self-hosting Renovate, tell us what version of Renovate you run.
No response
Describe the bug
I think this diff provides a good idea of the bug:
https:/DanySK/Tutorial-GitHub-Actions-Minimal/pull/4/files
Basically, if the version is followed by a comment, Renovate proposes to remove it.`
Relevant debug logs
Logs
Have you created a minimal reproduction repository?
No reproduction, but I have linked to a public repo where it occurs
The text was updated successfully, but these errors were encountered: