Fix crashes #636
Merged
Fix crashes #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeIlLeone
added
bug
|
Leaving this comment as a reminder for the issue: Plaintext patch for all plugins not being loaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord changed their webpack configuration a little bit, so that most of the common modules we need are now declared inline rather than pushed to the global array of chunks. This update fixes our injection to account for this change. It also includes fixes for the plaintext patches in our coremods, so that if initialization fails, missing coremods in the
replugged.coremods.coremodsnamespace will not cause a React crash.In the process, I've also swapped out the wait/signal start mechanism for a simpler means of intercepting the creation of Webpack chunks/modules. It adds needless complexity and is likely complicit in our perennial crashing issues. So far, with this mechanism removed, Replugged loads reliably on my machine. More testing is needed, especially on Windows and Linux, to confirm these stability improvements.