Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom GitLab endpoints for self-hosting #6399

Merged
merged 3 commits into from
May 12, 2023

Conversation

DerekJarvis
Copy link
Contributor

In some setups, self-hosting GitLab will require a different auth or tokenUrl than the baseUrl used to redirect the user to approve access. For example, there may be a firewall blocking WikiJS from accessing GitLab on the same server using the public baseUrl. This is the root of the problem I was facing here: #6377 .

This PR adds authorizationURL and tokenURL as configuration options for the GitLab authentication strategy. This allows the baseUrl to be set to redirect the user for approval, but have WikiJS use an internal tokenURL for validation. These new options may be left empty and they will be calculated from baseUrl the way they currently are. This is a non-breaking change.

@auto-assign auto-assign bot requested a review from NGPixel May 2, 2023 20:51
@NGPixel NGPixel merged commit fd00272 into requarks:main May 12, 2023
davidflypei pushed a commit to davidflypei/wiki that referenced this pull request Jun 13, 2023
…equarks#6399)

* Allow custom GitLab endpoints for self-hosting

---------

Co-authored-by: Nicolas Giard <[email protected]>
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
…equarks#6399)

* Allow custom GitLab endpoints for self-hosting

---------

Co-authored-by: Nicolas Giard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants