Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1241

Merged
merged 1 commit into from
Nov 5, 2014
Merged

Fix typo #1241

merged 1 commit into from
Nov 5, 2014

Conversation

alexanderGugel
Copy link
Contributor

No description provided.

@nylen
Copy link
Member

nylen commented Nov 5, 2014

👍 thanks!

nylen added a commit that referenced this pull request Nov 5, 2014
@nylen nylen merged commit 1fc4811 into request:master Nov 5, 2014
@rlidwka
Copy link

rlidwka commented Nov 5, 2014

I don't understand how is this a typo considering that almost every single node.js library shortens error to err.

@rlidwka
Copy link

rlidwka commented Nov 5, 2014

And we have another two err's in this very README.

@mikeal
Copy link
Member

mikeal commented Nov 5, 2014

For documentation it's best to be as explicit as possible, +1 for changing to error everywhere.

@nylen
Copy link
Member

nylen commented Nov 5, 2014

I personally prefer err in my own code too, but the issue here was that the callback function parameters said one thing (error) and the callback code said another (err). I would have accepted the fix either way, and we say error more often than err in the documentation.

@rlidwka
Copy link

rlidwka commented Nov 5, 2014

but the issue here was that the callback function parameters said one thing (error) and the callback code said another (err).

Oh, sorry... you're right, it's a typo

@alexanderGugel alexanderGugel deleted the patch-1 branch November 6, 2014 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants