Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HTTPS options that were not being passed to tunnel (@brichard19) #1383

Merged
merged 4 commits into from
Feb 2, 2015

Conversation

nylen
Copy link
Member

@nylen nylen commented Jan 28, 2015

This is a re-roll of #1380 with lint issues fixed and a few other cleanups. It passes more special HTTPS options to the tunnel, but there is more work needed after this: we still have to do some special stuff to get HTTPS tunnels and destinations to use a custom certificate authority. We will probably need to modify tunnel-agent in the future to fix this.

I'd like to release a new version after this change gets through, it has been a while and we have a couple of fixes that people have requested.

@nylen
Copy link
Member Author

nylen commented Jan 29, 2015

@seanstrom @simov @FredKSchott review pls?

@seanstrom
Copy link
Contributor

This seems okay, I believe this has been reviewed throughly else-where correct?

@nylen
Copy link
Member Author

nylen commented Jan 30, 2015

not sure about that, it's a pretty simple change though, and it includes a decent test case.

@seanstrom
Copy link
Contributor

ill give another look over today, then ill merge

@nylen
Copy link
Member Author

nylen commented Feb 2, 2015

merging and releasing new version

nylen added a commit that referenced this pull request Feb 2, 2015
Add missing HTTPS options that were not being passed to tunnel (@brichard19)
@nylen nylen merged commit b6cf839 into request:master Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants