fix tests with boundary by injecting boundry from header #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeal
added a commit
that referenced
this pull request
Jul 5, 2012
fix tests with boundary by injecting boundry from header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #277. I traced the error and found that it was due to a change that made the request text contain a randomly generated UUID. This made it so that it couldn't be compared with a static piece of text. I added a token to it and made it find the boundary in the header and put the boundary into the text. All tests pass now. More info is in my comments on #277.
I also clarified what happens when Squid isn't installed, so the person running the test knows that all tests that ran passed, that the test was skipped, and that squid needs to be installed to test tunneling.