Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI support #683

Merged
merged 2 commits into from
Oct 15, 2013
Merged

Travis CI support #683

merged 2 commits into from
Oct 15, 2013

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Oct 15, 2013

Added support for Travis CI and fixed the failing unit test in test-timeout.js (see e8dbcc8)

The callback is called twice and the second time a "ECONNRESET" error is
passed which previously broke the test.
@mikeal
Copy link
Member

mikeal commented Oct 15, 2013

the email i got on this showed that the build failed, any idea why?

@Turbo87
Copy link
Contributor Author

Turbo87 commented Oct 15, 2013

That is probably related to my first try before I wrote e8dbcc8. The last mail should have stated that the build is now fixed. Sorry for spaming your mailbox, I wasn't aware that it was sending mails to you too. The mails can be deactivated or configured to be only sent on failure.

mikeal added a commit that referenced this pull request Oct 15, 2013
@mikeal mikeal merged commit 86b93a2 into request:master Oct 15, 2013
@Turbo87
Copy link
Contributor Author

Turbo87 commented Oct 15, 2013

@mikeal in case you're not familiar with Travis CI: you might have to login there and enable it for this repo. I only enabled it for my forked repo and will switch that off as soon as I know that it's working properly here.

@mikeal
Copy link
Member

mikeal commented Oct 15, 2013

enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants