Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Resque::DataStore#reconnect for redis-rb v5.0 #756

Closed
wants to merge 1 commit into from

Conversation

mishina2228
Copy link
Contributor

@mishina2228 mishina2228 commented Sep 25, 2022

This PR will fix a part of #750.

Redis::Client#reconnect has been removed from redis-rb v5.0.0.
This PR replaces it with Resque::DataStore#reconnect.
It is available since Resque v1.27.0, so it is backward compatible.

`Redis::Client#reconnect` has been removed from redis-rb v5.0.0.
@mishina2228
Copy link
Contributor Author

Test failure is not directly related to this PR.
I created #757 for it.

@mishina2228 mishina2228 changed the title Use Resque::DataStore#reconnect instead for redis-rb v5.0 Use Resque::DataStore#reconnect for redis-rb v5.0 Oct 6, 2022
@mishina2228
Copy link
Contributor Author

@PatrickTulskie @iloveitaly
If you have a chance, would you mind review this PR? Thanks!

@PatrickTulskie PatrickTulskie self-requested a review October 6, 2022 14:01
Copy link
Contributor

@PatrickTulskie PatrickTulskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will work on a release for later today.

@PatrickTulskie
Copy link
Contributor

Actually going to close this since it looks like these changes are in #757 and that is passing CI... also it would have a merge conflict if I did this one first. Thanks!

@mishina2228
Copy link
Contributor Author

Thank you! and sorry for inconvenience caused by the conflict. 🙇
I didn't include the README change in #757, so I will submit another PR.

@mishina2228
Copy link
Contributor Author

I've just submitted #760.

@mishina2228 mishina2228 deleted the reconnect branch October 7, 2022 13:50
@PatrickTulskie
Copy link
Contributor

Gotcha. 4.7.0 has been released with this and the readme update. Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants