Tune rocksdb for multi-cf setup #1490

AhmedSoliman · 2024-05-01T13:11:45Z

Tune rocksdb for multi-cf setup

github-actions · 2024-05-01T13:41:27Z

Test Results

99 files ±0 99 suites ±0 8m 24s ⏱️ -24s
84 tests ±0 82 ✅ ±0 2 💤 ±0 0 ❌ ±0
216 runs ±0 210 ✅ ±0 6 💤 ±0 0 ❌ ±0

Results for commit b273b45. ± Comparison against base commit 6ea99f1.

tillrohrmann

Good improvements 👏

tillrohrmann · 2024-05-02T07:53:54Z

crates/partition-store/src/partition_store_manager.rs

- // we always need to enable atomic flush in case that the user disables wal at runtime
- db_options.set_atomic_flush(true);


Did this setting hurt performance?

Tune rocksdb for multi-cf setup

b273b45

AhmedSoliman marked this pull request as ready for review May 1, 2024 14:24

AhmedSoliman merged commit ec3b7bb into main May 1, 2024
5 checks passed

AhmedSoliman deleted the pr1490 branch May 1, 2024 14:24

tillrohrmann reviewed May 2, 2024

View reviewed changes

		// we always need to enable atomic flush in case that the user disables wal at runtime
		db_options.set_atomic_flush(true);