Unify RpcStyle message routing #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
AhmedSoliman
force-pushed
the
pr1511
branch
5 times, most recently
from
c73b8ea
to
9e861c5
Compare
tillrohrmann
approved these changes
May 15, 2024
There was a problem hiding this comment.
Great work @AhmedSoliman. The RpcRouter looks like a cool abstraction. The changes look good to me :-) +1 for merging.
| &self, | ||
| msg: restate_node_protocol::MessageEnvelope<Self::MessageType>, | ||
| ) -> impl std::future::Future<Output = ()> + Send { | ||
| self.handle_message(msg); |
There was a problem hiding this comment.
Should we log on debug or trace if a message could not be handled?
There was a problem hiding this comment.
I'm not sure about that one. I suspect that it can be a common place where the tracker token is dropped on timeouts and it would be noisy (and potentially not very useful) log message in this case.
Introduces types that makes it easier to perform Rpc-like interactions with Networking. - `RpcMessage` trait marks messages that carry a `CorrelationId`. A sane default correlation id is provided as `RequestId`. - `RpcRequest` trait defines request messages and their response types. - `RpcRouter<T: RpcRequest>` enables sending rpc request and awaiting responses with auto eviction of dropped requests. - `ResponseTracker` is a helper that manages tracking tokens for in-flight requests, this can be used in the future to replace large portions of IngressDispatcher. - Macros to help define RPC messages to reduce code noise in node-protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify RpcStyle message routing
Introduces types that makes it easier to perform Rpc-like interactions with Networking.
RpcMessagetrait marks messages that carry aCorrelationId. A sane default correlation id is provided asRequestId.RpcRequesttrait defines request messages and their response types.RpcRouter<T: RpcRequest>enables sending rpc request and awaiting responses with auto eviction of dropped requests.ResponseTrackeris a helper that manages tracking tokens for in-flight requests, this can be used in the future to replace large portions of IngressDispatcher.Stack created with Sapling. Best reviewed with ReviewStack.