Fix ingress #1559
Merged
Fix ingress #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rner cases where mixing requests/attach/send didn't work previously.
slinkydeveloper
force-pushed
the
issues/ingress-handler-id
branch
from
a3de048
to
4b2ad30
Compare
…workflow id, to notify whether they've been already submitted or not.
slinkydeveloper
force-pushed
the
issues/ingress-handler-id
branch
from
4b2ad30
to
2e18406
Compare
igalshilman
approved these changes
May 28, 2024
There was a problem hiding this comment.
Ok, thanks for the quick fix @slinkydeveloper.
Onces the e2e tests are passing I'm good to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two big changes to the ingress: